Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement is [not] distinct from #1117

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Implement is [not] distinct from #1117

merged 2 commits into from
Oct 15, 2021

Conversation

Dandandan
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added datafusion Changes in the datafusion crate sql SQL Planner labels Oct 14, 2021
@Dandandan Dandandan marked this pull request as draft October 14, 2021 17:17
alamb
alamb reviewed Oct 14, 2021
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

datafusion/src/optimizer/common_subexpr_eliminate.rs Outdated Show resolved Hide resolved
@Dandandan Dandandan force-pushed the isdistinctfrom branch 3 times, most recently from b3dc2c1 to 69582dd Compare October 15, 2021 06:46
@Dandandan Dandandan closed this Oct 15, 2021
@Dandandan Dandandan reopened this Oct 15, 2021
@Dandandan Dandandan marked this pull request as ready for review October 15, 2021 06:54
@Dandandan Dandandan changed the title [WIP] Implement is [not] distinct from Implement is [not] distinct from Oct 15, 2021
@Dandandan Dandandan requested a review from alamb October 15, 2021 08:33
alamb
alamb approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- nice work @Dandandan !

fyi @xudong963

datafusion/src/physical_plan/expressions/binary.rs
) -> Result<BooleanArray>
where
T: ArrowNumericType,
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 these look great

datafusion/tests/sql.rs Show resolved Hide resolved
@alamb alamb mentioned this pull request Oct 15, 2021
Closed
4 tasks
@Dandandan Dandandan merged commit 81fae23 into apache:master Oct 15, 2021
@alamb
Copy link
Contributor

alamb commented Oct 15, 2021

🎉

@xudong963
Copy link
Member

@Dandandan Good job！👏

@houqp houqp added the enhancement New feature or request label Nov 6, 2021
@alamb alamb mentioned this pull request Nov 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
datafusion Changes in the datafusion crate enhancement New feature or request sql SQL Planner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dandandan @alamb @xudong963 @houqp